refactor: Use prek workspaces#1236
Open
Techassi wants to merge 1 commit into
Open
Conversation
prek supports nested configs (called workspace mode) which enables us to use indivudal, crate specific config files. Those hooks are only triggered if there are changes in the subdirectoy. Currently, most of these configs are copy+pasted and we ideally want some kind of central config + input based on the prek project/workspace member to avoid this duplicated code. This was already raised as an issue upstream.
NickLarsenNZ
left a comment
NickLarsenNZ
left a comment
Member
There was a problem hiding this comment.
Does pre-commit support this?
Most users currently run pre-commit. If only prek supports this, then we probably need some kind of announcement before this gets merged.
Member
Author
|
No, this is prek specific, see https://prek.j178.dev/workspace/. So yes, this would need to be announced. |
Member
|
Let's wait until everyone has had time to update. |
Techassi
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triggered by #1233.
prek supports nested configs (called workspace mode) which enables us to use indivudal, crate specific config files. Those hooks are only triggered if there are changes in the subdirectoy which drastically cuts down on runtime during commit and in CI.
Currently, most of these configs are copy+pasted and we ideally want some kind of central config + input based on the prek project/workspace member to avoid this duplicated code. This was already raised as an issue upstream.