Skip to content

Use -isystem for libraries #3333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WardBrian merged 2 commits into from
Jun 18, 2026
+10 −7
Merged

Use -isystem for libraries #3333

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e91130e
Use -isystem for libraries
WardBrian Jun 17, 2026
12fe63f
Rename to INC_DIR_OPT
WardBrian Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions make/compiler_flags
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,13 @@ endif
##
O ?= 3

## Replace with -I if running into system conflicts
INC_FLAG ?= -isystem

@syclik syclik Jun 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just for clarity / readability, mind if we call this INC_DIR_OPT?

I don't think it's a "flag" like I'd think of a flag. It's more of an option.

The gcc doc says "-I" is short for "--include-directory" which is why I'm asking for INC_DIR_OPT instead of just INC_OPT.


## setup includes
INC ?= $(INC_FIRST) -I $(if $(MATH),$(MATH),.) -I $(EIGEN) -I $(BOOST) $(INC_SUNDIALS)
INC_SUNDIALS ?= -I $(SUNDIALS)/include -I $(SUNDIALS)/src/sundials
INC_GTEST ?= -I $(GTEST)/include -I $(GTEST)
INC ?= $(INC_FIRST) -I $(if $(MATH),$(MATH),.) $(INC_FLAG) $(EIGEN) $(INC_FLAG) $(BOOST) $(INC_SUNDIALS)
INC_SUNDIALS ?= $(INC_FLAG) $(SUNDIALS)/include $(INC_FLAG) $(SUNDIALS)/src/sundials
INC_GTEST ?= $(INC_FLAG) $(GTEST)/include $(INC_FLAG) $(GTEST)

## setup precompiler options
CPPFLAGS_BOOST ?= -DBOOST_DISABLE_ASSERTS
Expand Down Expand Up @@ -254,7 +257,7 @@ ifdef STAN_OPENCL
CPPFLAGS_OPENCL ?= -DSTAN_OPENCL -DOPENCL_DEVICE_ID=$(OPENCL_DEVICE_ID) -DOPENCL_PLATFORM_ID=$(OPENCL_PLATFORM_ID)
CPPFLAGS_OPENCL += -DCL_HPP_TARGET_OPENCL_VERSION=120 -DCL_HPP_MINIMUM_OPENCL_VERSION=120
CPPFLAGS_OPENCL += -DCL_HPP_ENABLE_EXCEPTIONS -Wno-ignored-attributes
CXXFLAGS_OPENCL ?= -I $(OPENCL)
CXXFLAGS_OPENCL ?= $(INC_FLAG) $(OPENCL)

ifdef INTEGRATED_OPENCL
CPPFLAGS_OPENCL += -DINTEGRATED_OPENCL=1
Expand Down Expand Up @@ -288,9 +291,9 @@ endif
ifdef TBB_LIB

ifdef TBB_INC
CXXFLAGS_TBB ?= -I $(TBB_INC)
CXXFLAGS_TBB ?= $(INC_FLAG) $(TBB_INC)
else
CXXFLAGS_TBB ?= -I $(TBB)/include
CXXFLAGS_TBB ?= $(INC_FLAG) $(TBB)/include
endif

# MacOS ld does not support --disable-new-dtags
Expand Down Expand Up @@ -321,7 +324,7 @@ ifeq ($(OS),Linux)
TBB_TARGETS ?= $(addprefix $(TBB_BIN)/lib,$(addsuffix $(LIBRARY_SUFFIX).2,$(TBB_LIBRARIES)))
endif

CXXFLAGS_TBB ?= -I $(TBB)/include
CXXFLAGS_TBB ?= $(INC_FLAG) $(TBB)/include
LDFLAGS_TBB ?= -Wl,-L,"$(TBB_BIN_ABSOLUTE_PATH)" $(LDFLAGS_FLTO_FLTO) $(LDFLAGS_OPTIM_TBB)

# Windows LLVM/Clang does not support -rpath, but is not needed on Windows anyway
Expand Down