Skip to content

Feature: add wallet network settings to app settings#20254

Merged
seanstrom merged 11 commits into
developfrom
seanstrom/remove-network-settings-feature-flag
Jun 5, 2024
Merged

Feature: add wallet network settings to app settings#20254
seanstrom merged 11 commits into
developfrom
seanstrom/remove-network-settings-feature-flag

Conversation

@seanstrom

@seanstrom seanstrom commented May 29, 2024

Copy link
Copy Markdown
Contributor

fixes #19947

Summary

  • This PR attempts to reveal the feature-flagged network settings inside wallet settings

Review notes

Testing notes

  • If testing with a development environment, remember to update the .env file with ENABLE_ALERT_BANNER=1 so the app will display the Testnet Mode banner.

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • Settings
  • Wallet Settings
  • Wallet Network Settings
  • Testnet Mode

Steps to test

status: ready

@seanstrom seanstrom self-assigned this May 29, 2024
@status-im-auto

status-im-auto commented May 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Jenkins Builds

Click to see older builds (38)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 0902d0c #1 2024-05-29 16:55:02 ~6 min tests 📄log
✔️ 0902d0c #1 2024-05-29 16:59:41 ~11 min ios 📱ipa 📲
✔️ 0902d0c #1 2024-05-29 17:01:46 ~13 min android 🤖apk 📲
✔️ 0902d0c #1 2024-05-29 17:01:49 ~13 min android-e2e 🤖apk 📲
✔️ d6d3456 #2 2024-05-30 11:59:29 ~5 min tests 📄log
✔️ d6d3456 #2 2024-05-30 12:04:52 ~10 min android 🤖apk 📲
✔️ d6d3456 #2 2024-05-30 12:04:57 ~10 min android-e2e 🤖apk 📲
✔️ d6d3456 #2 2024-05-30 12:05:04 ~10 min ios 📱ipa 📲
✔️ fb28cf0 #3 2024-05-31 10:09:21 ~4 min tests 📄log
✔️ fb28cf0 #3 2024-05-31 10:12:33 ~7 min android 🤖apk 📲
✔️ fb28cf0 #3 2024-05-31 10:14:07 ~9 min android-e2e 🤖apk 📲
✔️ fb28cf0 #3 2024-05-31 10:16:18 ~11 min ios 📱ipa 📲
✔️ 734e16e #4 2024-06-03 09:55:58 ~5 min tests 📄log
✔️ 734e16e #4 2024-06-03 10:01:30 ~10 min android-e2e 🤖apk 📲
✔️ 734e16e #4 2024-06-03 10:01:39 ~11 min android 🤖apk 📲
✔️ 734e16e #4 2024-06-03 10:06:36 ~16 min ios 📱ipa 📲
❌ 0dec553 #5 2024-06-04 06:56:01 ~4 min tests 📄log
✔️ 0dec553 #5 2024-06-04 07:01:05 ~9 min ios 📱ipa 📲
✔️ 0dec553 #5 2024-06-04 07:03:24 ~12 min android-e2e 🤖apk 📲
✔️ 0dec553 #5 2024-06-04 07:03:32 ~12 min android 🤖apk 📲
❌ d599a9d #6 2024-06-04 08:48:34 ~4 min tests 📄log
✔️ d599a9d #6 2024-06-04 08:55:12 ~11 min ios 📱ipa 📲
✔️ d599a9d #6 2024-06-04 08:57:30 ~13 min android-e2e 🤖apk 📲
✔️ d599a9d #6 2024-06-04 08:57:39 ~14 min android 🤖apk 📲
✔️ 7876f3d #7 2024-06-04 13:17:33 ~5 min tests 📄log
✔️ 7876f3d #7 2024-06-04 13:21:50 ~9 min ios 📱ipa 📲
✔️ 7876f3d #7 2024-06-04 13:24:10 ~12 min android-e2e 🤖apk 📲
✔️ 7876f3d #7 2024-06-04 13:24:19 ~12 min android 🤖apk 📲
❌ 538e479 #8 2024-06-04 17:25:09 ~4 min tests 📄log
✔️ 538e479 #8 2024-06-04 17:30:00 ~9 min ios 📱ipa 📲
✔️ 538e479 #8 2024-06-04 17:32:40 ~12 min android-e2e 🤖apk 📲
✔️ 538e479 #8 2024-06-04 17:32:45 ~12 min android 🤖apk 📲
✔️ aea8276 #9 2024-06-04 17:48:06 ~7 min tests 📄log
✔️ aea8276 #9 2024-06-04 17:50:51 ~9 min ios 📱ipa 📲
✔️ 5be5805 #10 2024-06-05 09:53:16 ~4 min tests 📄log
✔️ 5be5805 #10 2024-06-05 09:56:56 ~8 min android 🤖apk 📲
✔️ 5be5805 #10 2024-06-05 09:57:10 ~8 min android-e2e 🤖apk 📲
✔️ 5be5805 #10 2024-06-05 10:00:37 ~11 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 034984a #11 2024-06-05 10:39:57 ~2 min tests 📄log
✔️ 034984a #11 2024-06-05 10:45:34 ~8 min android-e2e 🤖apk 📲
✔️ 034984a #11 2024-06-05 10:45:38 ~8 min android 🤖apk 📲
✔️ 034984a #11 2024-06-05 10:49:47 ~12 min ios 📱ipa 📲
✔️ f05889d #13 2024-06-05 11:00:03 ~5 min tests 📄log
✔️ f05889d #13 2024-06-05 11:01:37 ~6 min android 🤖apk 📲
✔️ f05889d #13 2024-06-05 11:03:36 ~8 min android-e2e 🤖apk 📲
✔️ f05889d #13 2024-06-05 11:06:35 ~11 min ios 📱ipa 📲

@seanstrom seanstrom force-pushed the seanstrom/remove-network-settings-feature-flag branch from 0902d0c to d6d3456 Compare May 30, 2024 11:54
@status-im-auto

status-im-auto commented May 30, 2024

Copy link
Copy Markdown
Member

88% of end-end tests have passed

Total executed tests: 51
Failed tests: 3
Expected to fail tests: 3
Passed tests: 45
Not executed tests: 1

IDs of not executed tests: 702936 

IDs of failed tests: 727230,727229,702947 

IDs of expected to fail tests: 703503,702807,727232

Not executed tests (1)

Click to expand
  • Rerun not executed tests

    • Failed tests (3)

    Click to expand
  • Rerun failed tests

    • Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947

    Device 2: Find `LogInButton` by `accessibility id`: `login-button`
    Device 2: Tap on found: LogInButton 

    Test setup failed: activity_center/test_activity_center.py:274: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:425: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    # STEP: Getting ETH amount in the wallet of the sender before transaction
    Device 1: Find WalletTab by accessibility id: wallet-stack-tab 

    critical/test_wallet.py:120: in test_wallet_send_asset_from_drawer
    sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx()
critical/test_wallet.py:41: in _get_balances_before_tx
    self.wallet_1.wallet_tab.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: WalletTab by accessibility id: `wallet-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    2. test_wallet_send_eth, id: 727229

    Device 1: Tap on found: LogInButton
    Device 1: Find Button by accessibility id: done 

    critical/test_wallet.py:111: in test_wallet_send_eth
    self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send)
../views/wallet_view.py:100: in send_asset
    self.confirm_transaction()
../views/wallet_view.py:88: in confirm_transaction
    self.done_button.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `done` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Expected to fail tests (3)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Find Text by xpath: //*[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_group_chat.py:97: in test_group_chat_join_send_text_messages_push
    self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120)
../views/chat_view.py:225: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent

    [[Issue with a message status - Sent instead of Delivered, https://github.com//issues/20126]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_watch_only_account, id: 727232

    Device 1: Text is 0x8d2413447ff297d30bdc475f6d5cb00254685aae
    Device 1: Click system back button 

    critical/test_wallet.py:214: in test_wallet_add_remove_watch_only_account
    self.home_view.driver.fail(
base_test_case.py:178: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Incorrect address '0x8d2413447ff297d30bdc475f6d5cb00254685aae' is shown when swiping between accounts, expected one is '0x8d2413447ff297d30bdc475f6d5cb00254685aae'

    [[Missing networks in account address, https://github.com//issues/20166]]

    Device sessions

    Passed tests (45)

    Click to expand

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    4. test_group_chat_reactions, id: 703202
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    @status-im-auto

    status-im-auto commented May 30, 2024

    Copy link
    Copy Markdown
    Member

    86% of end-end tests have passed

    Total executed tests: 51
Failed tests: 3
Expected to fail tests: 4
Passed tests: 44
Not executed tests: 1

    IDs of not executed tests: 702936 

    IDs of failed tests: 727230,702809,727229 

    IDs of expected to fail tests: 703495,703503,702807,727232

    Not executed tests (1)

    Click to expand
  • Rerun not executed tests

    • Failed tests (3)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809

    Device 1: Looking for a message by text: quote reply (one row)
    Device 2: Looking for a message by text: quote reply (one row) 

    critical/chats/test_public_chat_browsing.py:985: in test_community_markdown_support
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 bold text in asterics is not displayed with markdown in community channel for the recipient (device 1)



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    # STEP: Getting ETH amount in the wallet of the sender before transaction
    Device 1: Find WalletTab by accessibility id: wallet-stack-tab 

    critical/test_wallet.py:120: in test_wallet_send_asset_from_drawer
    sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx()
critical/test_wallet.py:41: in _get_balances_before_tx
    self.wallet_1.wallet_tab.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: WalletTab by accessibility id: `wallet-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    2. test_wallet_send_eth, id: 727229

    Device 1: Tap on found: LogInButton
    Device 1: Find Button by accessibility id: done 

    critical/test_wallet.py:111: in test_wallet_send_eth
    self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send)
../views/wallet_view.py:100: in send_asset
    self.confirm_transaction()
../views/wallet_view.py:88: in confirm_transaction
    self.done_button.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `done` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Expected to fail tests (4)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement 

    critical/chats/test_group_chat.py:466: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

    [[Chat is not unmuted after expected time: https://github.com//issues/19627]]

    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Find Text by xpath: //*[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_group_chat.py:97: in test_group_chat_join_send_text_messages_push
    self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120)
../views/chat_view.py:225: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent

    [[Issue with a message status - Sent instead of Delivered, https://github.com//issues/20126]]

    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_watch_only_account, id: 727232

    Device 1: Text is 0x8d2413447ff297d30bdc475f6d5cb00254685aae
    Device 1: Click system back button 

    critical/test_wallet.py:214: in test_wallet_add_remove_watch_only_account
    self.home_view.driver.fail(
base_test_case.py:178: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Incorrect address '0x8d2413447ff297d30bdc475f6d5cb00254685aae' is shown when swiping between accounts, expected one is '0x8d2413447ff297d30bdc475f6d5cb00254685aae'

    [[Missing networks in account address, https://github.com//issues/20166]]

    Device sessions

    Passed tests (44)

    Click to expand

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    4. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    @seanstrom seanstrom force-pushed the seanstrom/remove-network-settings-feature-flag branch from d6d3456 to fb28cf0 Compare May 31, 2024 10:04
    @VolodLytvynenko VolodLytvynenko self-assigned this May 31, 2024
    @VolodLytvynenko VolodLytvynenko force-pushed the seanstrom/remove-network-settings-feature-flag branch from fb28cf0 to 734e16e Compare June 3, 2024 09:50
    @VolodLytvynenko

    VolodLytvynenko commented Jun 3, 2024 •
    edited
    Loading

    Copy link
    Copy Markdown
    Contributor

    Hi @seanstrom, I'm trying to understand how to achieve the "testnet is not available" status as shown in this design for Optimism.

    I encountered a toast message saying "the provider for the following chain is down: Arbitrum" even though Arbitrum is shown as active in the wallet settings.
    image

    Should the network be displayed as "testnet is not available" when the provider is down?

    Logs:

    Status-debug-logs.zip

    @smohamedjavid

    smohamedjavid commented Jun 3, 2024

    Copy link
    Copy Markdown
    Contributor

    Should the network be displayed as "testnet is not available" when the provider is down?

    @VolodLytvynenko - No, The label Testnet is not available is meant if the user changes the network configuration for a chain (not available in mobile yet), resulting in a network error.

    On the other hand, the desktop app shows the Sepolia active label even if the provider is down.

    @VolodLytvynenko

    VolodLytvynenko commented Jun 3, 2024

    Copy link
    Copy Markdown
    Contributor

    Should the network be displayed as "testnet is not available" when the provider is down?

    @VolodLytvynenko - No, The label Testnet is not available is meant if the user changes the network configuration for a chain (not available in mobile yet), resulting in a network error.

    On the other hand, the desktop app shows the Sepolia active label even if the provider is down.

    @smohamedjavid Thank you for the clarification.

    @seanstrom PR is ready to be merged. Thank you for your work!

    @seanstrom

    seanstrom commented Jun 3, 2024

    Copy link
    Copy Markdown
    Contributor Author

    @Francesca-G can you do a design review for this PR please? 🙏

    Francesca-G
    Francesca-G reviewed Jun 3, 2024
    View reviewed changes

    @Francesca-G Francesca-G left a comment

    Copy link
    Copy Markdown

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Here's the review 🙏

    @seanstrom seanstrom force-pushed the seanstrom/remove-network-settings-feature-flag branch 2 times, most recently from d599a9d to 7876f3d Compare June 4, 2024 13:11
    @seanstrom

    seanstrom commented Jun 4, 2024

    Copy link
    Copy Markdown
    Contributor Author

    @Francesca-G Oki doki 🧑‍🌾
    I think we're ready for another design review 🎨

    Francesca-G
    Francesca-G reviewed Jun 4, 2024
    View reviewed changes

    @Francesca-G Francesca-G left a comment

    Copy link
    Copy Markdown

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @seanstrom thank for addressing the issues!

    the blur and the color issues seem to be fixed. nice job! ✨
    the vertical spacing still needs some adjusting (Figma)

    Screenshot 2024-06-04 alle 16 09 38

    Feel free to create a separate issue for the blur as it's a recurring problem, thanks for pointing it out 🙏

    @seanstrom seanstrom force-pushed the seanstrom/remove-network-settings-feature-flag branch from 538e479 to aea8276 Compare June 4, 2024 17:40
    @seanstrom

    seanstrom commented Jun 4, 2024

    Copy link
    Copy Markdown
    Contributor Author

    @Francesca-G thanks for the feedback!
    I've tried tweaking the spacing/alignment of these elements to closely match the designs 📏
    So I think I'm ready for another design review 🙏

    Francesca-G
    Francesca-G approved these changes Jun 5, 2024
    View reviewed changes

    @Francesca-G Francesca-G left a comment

    Copy link
    Copy Markdown

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks good now ✨ nice job!

    @seanstrom seanstrom force-pushed the seanstrom/remove-network-settings-feature-flag branch from aea8276 to 5be5805 Compare June 5, 2024 09:48
    @seanstrom seanstrom force-pushed the seanstrom/remove-network-settings-feature-flag branch 2 times, most recently from 034984a to 66dfd02 Compare June 5, 2024 10:53
    seanstrom added 11 commits June 5, 2024 11:54
    @seanstrom seanstrom force-pushed the seanstrom/remove-network-settings-feature-flag branch from 66dfd02 to f05889d Compare June 5, 2024 10:54
    @seanstrom seanstrom merged commit b4a0e74 into develop Jun 5, 2024
    @seanstrom seanstrom deleted the seanstrom/remove-network-settings-feature-flag branch June 5, 2024 11:17
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @Francesca-G Francesca-G Francesca-G approved these changes
    +2 more reviewers
    @smohamedjavid smohamedjavid smohamedjavid approved these changes
    @mohsen-ghafouri mohsen-ghafouri mohsen-ghafouri approved these changes
    Reviewers whose approvals may not affect merge requirements

    Assignees

    @seanstrom seanstrom

    @VolodLytvynenko VolodLytvynenko

    Labels

    request-manual-qa test cases added Tested - OK

    Projects

    Pipeline for QA
    Archived in project

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    [Epic] - Feature - Mobile Wallet Settings - Network Settings

    6 participants

    @seanstrom @status-im-auto @VolodLytvynenko @smohamedjavid @mohsen-ghafouri @Francesca-G