Replace onebox graph with NewServerFx [wip]#10319
Draft
stephanos wants to merge 16 commits into
Draft
Conversation
stephanos
force-pushed
the
stephanos/rm-onebox
branch
14 times, most recently
from
6e911b9 to
d2bd371
Compare
stephanos
commented
May 18, 2026
| @@ -69,8 +59,6 @@ import ( | |||
|
|
|||
| type ( | |||
| TemporalImpl struct { | |||
Contributor
Author
There was a problem hiding this comment.
There are many more refactorings that can be done here, but keeping it to an absolute minimum here.
stephanos
force-pushed
the
stephanos/rm-onebox
branch
3 times, most recently
from
e935010 to
4f3cee0
Compare
stephanos
force-pushed
the
stephanos/rm-onebox
branch
11 times, most recently
from
832deab to
6ea1fbd
Compare
stephanos
force-pushed
the
stephanos/rm-onebox
branch
2 times, most recently
from
98a8892 to
6357fc6
Compare
stephanos
commented
Jun 5, 2026
| // WithFxOptions appends fx options to a specific service's fx graph. This | ||
| // implies a dedicated cluster because custom fx options cannot be shared | ||
| // across tests. | ||
| func WithFxOptions(serviceName primitives.ServiceName, opts ...fx.Option) TestOption { |
stephanos
commented
Jun 5, 2026
| // RPCAddress and HTTPAddress will be filled in | ||
| }, | ||
| } | ||
| clusterConfigs[clusterIndex].ServiceFxOptions = params.ServiceOptions |
stephanos
force-pushed
the
stephanos/rm-onebox
branch
3 times, most recently
from
4e8718a to
0f2897e
Compare
stephanos
force-pushed
the
stephanos/dlq-testhooks
branch
2 times, most recently
from
c09a0a9 to
a680fb1
Compare
stephanos
force-pushed
the
stephanos/rm-onebox
branch
from
0f2897e to
35162d8
Compare
stephanos
force-pushed
the
stephanos/rm-onebox
branch
from
35162d8 to
0bf0200
Compare
stephanos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This is the root onebox replacement branch. Keep it draft until the smaller PRs below land or get folded back intentionally.
Goal
tests/testcore/onebox.goshould start services throughtemporal.NewServerFxinstead of maintaining a separate per-service Fx graph. Any remaining bridge from onebox into the production graph should be either normal embedded-server configuration, a focused testhook, or test-owned client/setup code.Split plan
The child PRs should each tell one coherent story:
Remaining pieces still need their own small PRs or an explicit decision before this parent can be reduced:
temporal.NewServerFxand split the onebox-specific startup polish that remains: frontend HTTP config in per-service onebox configs.temporalpackage diff. Keep only options that are justified outside onebox, especiallyWithTestHooks,WithChasmLibraries, and custom archiver factories.Review framing
Review the final parent by boundary, not by old hook name: