encode schedules behavior with workflow pause#10807
Draft
spkane31 wants to merge 4 commits into
Draft
Conversation
spkane31
commented
Jun 22, 2026
| return true | ||
| case enumspb.SCHEDULE_OVERLAP_POLICY_TERMINATE_OTHER: | ||
| // CHASM terminates the paused workflow and continues; V1 stalls (bug). | ||
| return isCHASM |
Contributor
Author
There was a problem hiding this comment.
This is the bug that I found w/ claude assistance. In v1 schedules the schedules workflow is stuck, but CHASM will deliver the termination command.
As a larger point, the TERMINATE_OTHER policy does not work well with workflow pause because a termination requires a workflow task to dispatch, which in turn requires the workflow to be unpaused.
spkane31
force-pushed
the
spk/schedules-pause-wf-interaction
branch
from
c126228 to
33dbba8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Adding tests to validate the
OverlapPolicybehavior with paused workflows.Why?
In preparation for a workflow pause release, encoding the overlap policy and workflow pause interactions operate the same for CHASM and V1 schedules.
How did you test it?
Potential risks
Test changes only