Solution for issue #36, Valid Parenthesis in python#164
Open
bpbrum wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear the-vampiire,
this is my solution for Issue 36, Valid Parenthesis, in python
Approach / Though Process
From the start, I felt pairwise comparison was the way to go, and indeed it evolved naturally. I decided also to add a test against empty strings right at the beginning to avoid the burden of making all the comparisons if it was supposed to return True anyway. I re-used my "testing" function from the PR for Issue 3, but I feel it could be improved.
Problems during the solution process
As mentioned before, the solutione evolved naturally, and I had basically no problems.
Instructions to run
The file is coded to run the tests on import or open (harcoded into name == "main"), but the function has_valid_parens can be imported for testing. The input is a merely a string.
-- bpbrum