Fix ALTER lock order on continuous aggregates#10077
Open
melihmutlu wants to merge 2 commits into
Open
Conversation
Concurrent ALTER operations on a continuous aggregate could deadlock with each other and with DROP because they acquired locks on the cagg's relations (user view, mat hypertable, partial view, direct view) in inconsistent orders Establish a canonical lock order and route every ALTER through a shared ts_continuous_agg_lock_relations() helper that takes the locks it needs upfront in that order, which removes the deadlock.
|
@pnthao, @natalya-aksman: please review this pull request.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concurrent ALTER operations on a continuous aggregate could deadlock
with each other and with DROP because they acquired locks on the cagg's
relations (user view, mat hypertable, partial view, direct view) in
inconsistent orders
Establish a canonical lock order and route every ALTER through a shared
ts_continuous_agg_lock_relations() helper that takes the locks it needs
upfront in that order, which removes the deadlock.