Skip to content

Move clang-tidy to ARM runner #10080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akuzm wants to merge 3 commits into
base: main
Choose a base branch
from
+22 −21
Open

Move clang-tidy to ARM runner #10080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5eea2d7
Move clang-tidy to ARM runner
akuzm Jun 17, 2026
275b1db
gcc?
akuzm Jun 17, 2026
9481edf
fix clang-tidy warnings in unit tests
akuzm Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/gh_matrix_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,8 @@ def macos_config(overrides):
# timescale/timescaledb repository.
# See the available runners here:
# https://github.com/timescale/timescaledb/actions/runners
#
# Also run clang-tidy on it, because it's the fastest debug configuration.
if os.environ.get("GITHUB_REPOSITORY") == "timescale/timescaledb":
m["include"].append(
build_debug_config(
Expand All @@ -204,6 +206,9 @@ def macos_config(overrides):
# code. The actual architecture for our ARM CI runner is reported as:
# -imultiarch aarch64-linux-gnu - -mlittle-endian -mabi=lp64 -march=armv8.2-a+crypto+fp16+rcpc+dotprod
"pg_extra_args": "--enable-debug --enable-cassert --without-llvm CFLAGS=-march=armv8.2-a+crypto",
"cc": "clang",
"cxx": "clang++",
"tsdb_build_args": "-DLINTER=ON -DWARNINGS_AS_ERRORS=ON",
}
)
)
Expand All @@ -222,15 +227,11 @@ def macos_config(overrides):
)
)

# Test latest postgres release without telemetry. Also run clang-tidy on it
# because it's the fastest one.
# Test latest postgres release without telemetry.
m["include"].append(
build_without_telemetry(
{
"pg": PG18_LATEST,
"cc": "clang",
"cxx": "clang++",
"tsdb_build_args": "-DLINTER=ON -DWARNINGS_AS_ERRORS=ON",
}
)
)
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/linux-build-and-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ jobs:
- name: Build TimescaleDB
run: |
# Show the actual architecture this CI runner has
"$CC" -march=native -E -v - </dev/null 2>&1 | grep cc1
gcc -march=native -E -v - </dev/null 2>&1 | grep cc1

./bootstrap -DCMAKE_BUILD_TYPE="${{ matrix.build_type }}" \
-DPG_SOURCE_DIR=$HOME/$PG_SRC_DIR -DPG_PATH=$HOME/$PG_INSTALL_DIR \
Expand Down
10 changes: 5 additions & 5 deletions test/src/test_jsonb_utils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@
*/

#include <postgres.h>

#include <fmgr.h>
#include <funcapi.h>
#include <utils/fmgrprotos.h>

#include "jsonb_utils.h"
#include "test_utils.h"
#include "ts_catalog/compression_settings.h"
#include "utils/jsonb.h"
#include <fmgr.h>
#include <funcapi.h>

// Declare jsonb_in explicitly
extern Datum jsonb_in(PG_FUNCTION_ARGS);

const char *
jsonb_to_cstring(Jsonb *jsonb)
Expand Down
2 changes: 1 addition & 1 deletion test/src/test_stats.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ test_eviction()
Oid uncompressed_relid = 54321;
int32 slot_indices[NUM_SLOTS] = { 0 };
uint64 slot_seqno[NUM_SLOTS] = { 0 };
uint64 sum_lifespan = 0;
double sum_lifespan = 0;
double sumsq_lifespan = 0;
int32 num_evictions = 0;
uint64 min_lifespan = UINT64_MAX;
Expand Down
18 changes: 9 additions & 9 deletions tsl/test/src/test_fastlanes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,17 +611,17 @@ test_fl256_ffor_144x13b()
#define CALC_MINMAX(min, max, values, n) \
do \
{ \
min = *values; \
max = *values; \
for (size_t i = 0; i < n; ++i) \
(min) = *(values); \
(max) = *(values); \
for (size_t i = 0; i < (n); ++i) \
{ \
if (min > values[i]) \
if ((min) > (values)[i]) \
{ \
min = values[i]; \
(min) = (values)[i]; \
} \
if (max < values[i]) \
if ((max) < (values)[i]) \
{ \
max = values[i]; \
(max) = (values)[i]; \
} \
} \
} while (0)
Expand Down Expand Up @@ -760,9 +760,9 @@ test_randomized()
#define CHECK_VALUES(V, SZ, E) \
do \
{ \
for (int i = 0; i < SZ; ++i) \
for (int i = 0; i < (SZ); ++i) \
{ \
TestAssertInt64Eq(V[i], E); \
TestAssertInt64Eq((V)[i], (E)); \
} \
} while (0)

Expand Down
Loading