-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: route new task runs to a parallel task_run_v2 table #4000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
d-cs
wants to merge
75
commits into
main
Choose a base branch
from
runstore-table-redirect
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 64 commits
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
a86635c
chore(run-store): scaffold @internal/run-store package
d-cs d4c1ff4
feat(run-store): add shared types and the RunStore interface
d-cs 6d7abab
chore(run-store): use .js extensions in index re-exports for Node16 r…
d-cs 010cf17
feat(run-store): add NoopRunStore test double
d-cs 72a7462
feat(run-store): add PostgresRunStore with createRun
d-cs 2e63223
feat(run-store): implement createCancelledRun and createFailedRun
d-cs f8456c1
feat(run-store): implement attempt lifecycle, cancel, and fail methods
d-cs f1ab6ae
feat(run-store): implement expiry, dequeue-lock, version, and checkpo…
d-cs f66bbad
feat(run-store): implement reschedule, debounce, metadata, idempotenc…
d-cs 56ec707
feat(run-store): wire RunStore into run-engine SystemResources and we…
d-cs 01bbc67
fix(run-store): align create-input types with the columns callers act…
d-cs de52aaa
refactor(run-engine): route run creation through RunStore
d-cs 4826117
fix(run-store): allow optional machinePreset in recordRetryOutcome (l…
d-cs 8650e40
refactor(run-engine): route attempt lifecycle, cancel, and fail write…
d-cs d530eb1
refactor(run-engine): route expiry and dequeue-lock writes through Ru…
d-cs 4ec5aab
fix(run-store): allow undefined maxDurationInSeconds in lockRunToWork…
d-cs 109c6a7
refactor(run-engine): route checkpoint, delayed, pending-version, and…
d-cs 2fbdc5d
refactor(webapp): route run metadata, idempotency-key, and reschedule…
d-cs 1a5ccdc
refactor(webapp): route tag and realtime-stream appends through RunStore
d-cs 60565cf
fix(run-store): short-circuit expireRunsBatch on an empty runIds array
d-cs 3c22b32
Merge main into run-store-write-adapter
d-cs 76f3494
fix(webapp): inject runStore into UpdateMetadataService
d-cs c5226a2
feat(run-store): add TaskRun read methods to the run store
d-cs 13d5364
feat(run-store): add full-row read overload to the run store
d-cs cfa9052
refactor(run-engine): route TaskRun reads through the run store
d-cs 5b74b48
refactor(webapp): route service-layer TaskRun reads through the run s…
d-cs 5683952
refactor(webapp): route presenter TaskRun reads through the run store
d-cs 126b05f
refactor(webapp): route API and loader TaskRun reads through the run …
d-cs f59abe7
refactor(webapp): hydrate parent-model TaskRun reads through the run …
d-cs cb12430
chore(scripts): flag recover-stuck-runs raw TaskRun read for table cu…
d-cs ae57f25
chore(webapp): add server-changes entry for run-store read routing
d-cs fcc26d4
test(webapp): mock db.server in the new run-store read tests
d-cs 789e107
test(webapp): drop the cancelTaskAttemptDependencies container test
d-cs e20e451
Merge branch 'main' into runstore-read-path
d-cs 650a081
feat(core): add KSUID run-id minting and an isKsuidId discriminator
d-cs 40aea1b
feat(database): add the task_run_v2 table
d-cs 72af7aa
feat(database): drop incoming foreign keys referencing TaskRun
d-cs 1e60662
feat(database): mirror TaskRun relations on TaskRunV2
d-cs 0a591fb
test(testcontainers): strip run foreign keys after schema push
d-cs f8c1a04
feat(run-store): route run reads and writes by id format
d-cs e174341
feat(run-store): both-table merged keyset cursor for findRuns
d-cs 37b7f97
fix(webapp): read runs across both run tables with a time keyset
d-cs 658b385
feat(run-store): read non-id predicates across both run tables
d-cs 47610ee
feat(webapp): per-org cutover flag for the v2 run table
d-cs 837ee01
Merge branch 'main' into runstore-read-path
d-cs 912a504
feat(replication): co-publish additional tables and reconcile existin…
d-cs 3549341
feat(webapp): stream task_run_v2 into ClickHouse
d-cs 7732861
Merge branch 'main' into runstore-read-path
d-cs 435e895
Merge branch 'runstore-read-path' into runstore-table-redirect
d-cs 4410999
test(webapp): de-flake the task_run_v2 replication streaming test
d-cs e72d9fb
Merge branch 'main' into runstore-table-redirect
d-cs fd06ef4
fix(run-store): guard findRuns skip and skip the non-candidate table …
d-cs 5ebea98
fix(run-store): correct single-table findRuns ordering and cross-tabl…
d-cs 6a2b4e3
fix(webapp): serialise idempotency claims for v2-cutover orgs
d-cs b925f25
fix(database,replication): pin task_run_v2 REPLICA IDENTITY FULL and …
d-cs 5282e01
fix(webapp): resolve cross-table run parent/root/children in presenters
d-cs 24b0f87
fix(run-store): prefer task_run_v2 on cross-table single-row reads
d-cs df8a7a8
fix(database): drop unused task_run_v2 m2m relations
d-cs 18a67c2
fix(run-store): guard cross-table cursor/take and route plain id reads
d-cs f641091
fix(webapp): back idempotency claims with Redis when the mollifier is…
d-cs 388dd66
fix(webapp): serve realtime run feeds across both run tables
d-cs eeb1079
fix(webapp): lock runTableV2 on the global flags page
d-cs 3d4ca9e
fix(webapp): scope cross-table run hierarchy hydration to the environ…
d-cs 59dd560
fix(webapp): swallow the aborted sibling fetch in the realtime merge
d-cs 59866a9
fix(webapp): harden the realtime merge against orphaned fetch rejections
d-cs e44af57
Merge remote-tracking branch 'origin/main' into runstore-table-redirect
d-cs 0084704
fix(webapp): gate runTableV2 on native realtime instead of merging El…
d-cs 760c24c
fix(webapp): gate runTableV2 on the native realtime backend
d-cs c4d8c4b
fix(webapp): serve task_run_v2 runs over Electric realtime
d-cs ef54cb9
fix(webapp,run-engine): close cross-table gaps in the task_run_v2 mix…
d-cs 3218843
test(run-engine): cover cross-table cancel cascade in the task_run_v2…
d-cs e64e950
fix(run-store): reject findRuns take without orderBy across both run …
d-cs 8ee83c5
test(run-store): drop obsolete findRuns take-without-orderBy cap test
d-cs 0143ade
fix(webapp): close pass-2 cross-table gaps (span-detail 500, one-time…
d-cs 5f14bf3
fix(webapp): gate runTableV2 on native realtime and drop the Electric…
d-cs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.