Add Trace.fromIOLocal for building a Trace[IO] from an existing IOLocal#1336
Open
kubukoz wants to merge 1 commit into
Open
Add Trace.fromIOLocal for building a Trace[IO] from an existing IOLocal#1336kubukoz wants to merge 1 commit into
kubukoz wants to merge 1 commit into
Conversation
Extracts the anonymous IOLocal-backed instance out of `ioTrace` into a public `fromIOLocal` constructor that takes a pre-constructed `IOLocal[Span[IO]]` and returns a `Trace[IO]` directly (no `IO`). This lets callers retain ownership of the `IOLocal`, so the current `Span[IO]` remains accessible via `local.get`. `ioTrace` now delegates to `fromIOLocal`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a public
Trace.fromIOLocal(local: IOLocal[Span[IO]]): Trace[IO]constructor by extracting the anonymousIOLocal-backed instance that previously lived insideioTrace.ioTracenow delegates to it:Why
Instances built via
Trace.ioTrace/Trace.ioTraceForEntryPointfully encapsulate theirIOLocal[Span[IO]], so there is no way to reach the underlying currentSpan[IO](or dump it to aThreadLocalwith typelevel/cats-effect#3636).🤖 Generated with Claude Code