fix: address review feedback from @coderabbitai[bot] on #7358#23
Closed
thepastaclaw wants to merge 1 commit into
Closed
fix: address review feedback from @coderabbitai[bot] on #7358#23thepastaclaw wants to merge 1 commit into
thepastaclaw wants to merge 1 commit into
Conversation
✅ No Merge Conflicts DetectedThis PR currently has no conflicts with other open PRs. |
Author
|
Closing this because PastaClaw's automated review-feedback fix PR workflow is now disabled. We no longer want helper/fix PRs opened into other people's PR branches from review comments; review-bot should report/comment/escalate instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses 3 review comment(s) from @coderabbitai[bot] on dashpay#7358.
Original PR author: @vijaydasmp
Review comments addressed:
**Do not modify vendored UniValue sources withou](dashpay#7358 (comment))
**Use mock time in the assertion to avoid reintrod](dashpay#7358 (comment))
**Use
next(...)with an explicit assertion inste](dashpay#7358 (comment))Original PR: dashpay#7358
Automated fix by thepastaclaw
🤖 This was generated by an automated review bot.
Don't want automated PRs or comments on your code? You can opt out by replying here or messaging @PastaPastaPasta on Slack — we'll make sure the bot skips your PRs/repos going forward.