logout user in the case that the underlying connection gets disconnected

[JacobBarthelmeh]

Follow up to item 4 from #270

[Copilot]

Pull request overview

This PR ensures that an authenticated user session is properly logged out when the underlying communication channel is abruptly disconnected (not just on a clean COMM_CLOSE). It also defensively clears any stale auth session state during wh_Server_Init, in case the externally-owned auth context carries a leftover session from a prior connection.

Changes:

• In wh_Server_SetConnected, invoke wh_Auth_Logout on the transition to WH_COMM_DISCONNECTED when a user is currently active.
• In wh_Server_Init, after binding the externally-owned auth context, log out any stale active user; fall back to zeroing the user struct if logout fails.
• Add _whTest_Auth_AbruptDisconnect test that uses a wrapping test_Logout callback to verify the disconnect path triggers exactly one logout and that repeated disconnects are no-ops.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/wh_server.c	Adds logout-on-disconnect in wh_Server_SetConnected and stale-session cleanup in wh_Server_Init.
test/wh_test_auth.c	Adds a logout-counting callback and a memory-transport test verifying logout fires on abrupt disconnect and is idempotent.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

[bigbrett]

LGTM. A few questions and a nit but nothing that would block merge

[billphipps]

Please consider unconditionally zeroing userid when logging out. Please resolve additional comments.

[JacobBarthelmeh]

@bigbrett and @billphipps , I believe I've addressed the current feedback. Thank you for reviewing

[wolfSSL-Fenrir-bot]

Fenrir Automated Review — PR #383

Scan targets checked: wolfhsm-core-bugs, wolfhsm-crypto-bugs, wolfhsm-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

[wolfSSL-Fenrir-bot]

Fenrir Automated Review — PR #383

Scan targets checked: wolfhsm-core-bugs, wolfhsm-crypto-bugs, wolfhsm-src

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

[JacobBarthelmeh]

@bigbrett addressed the logging placement feedback, reviewed a re-kick off of AI reviews and rebased onto master. I think it's ready for re-review, thanks for your patience on this PR.