-
Notifications
You must be signed in to change notification settings - Fork 1k
AES-GCM-SIV: Add implementation in C and assembly #10807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SparkiDev
wants to merge
1
commit into
wolfSSL:master
Choose a base branch
from
SparkiDev:aes_gcm_siv_asm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+25,538
−1,564
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,148 @@ | ||
| name: AES-GCM-SIV (RFC 8452) tests | ||
|
|
||
| # START OF COMMON SECTION | ||
| on: | ||
| push: | ||
| branches: [ 'release/**' ] | ||
| pull_request: | ||
| types: [opened, synchronize, reopened, ready_for_review] | ||
| branches: [ '*' ] | ||
| # Weekday-morning cron (10:00 UTC) seeds the master-scoped ccache that PR runs | ||
| # restore (cross job only); re-runs --build-only on the default branch. | ||
| schedule: | ||
| - cron: '40 10 * * 1-5' | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
| # END OF COMMON SECTION | ||
|
|
||
| jobs: | ||
| # Native x86_64 'make check'. These are --enable-cryptonly (WOLFCRYPT_ONLY) | ||
| # builds, so check runs testwolfcrypt - which includes aesgcm_siv_test (the | ||
| # RFC 8452 KATs) - but not the TLS-only tests/unit.test (the tests/api group, | ||
| # test_wc_AesGcmSivEncryptDecrypt, needs a non-cryptonly build). One runner | ||
| # per config: | ||
| # - siv-c-only : no asm, exercises the software (table) POLYVAL + C CTR. | ||
| # - siv-intelasm : PCLMUL/AVX/VAES/AVX512 POLYVAL + pipelined CTR, whichever | ||
| # the runner CPU selects at runtime. | ||
| # - siv-all : SIV alongside --enable-all to catch integration regressions. | ||
| # - siv-smallstack : SIV's key schedules / derived keys live on the stack. | ||
| make_check: | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| config: | ||
| - '--enable-cryptonly --enable-aesgcm-siv' | ||
| - '--enable-cryptonly --enable-intelasm --enable-sp-asm --enable-aesgcm-siv' | ||
| - '--enable-cryptonly --enable-all-crypto --enable-intelasm --enable-sp-asm --enable-aesgcm-siv' | ||
| - '--enable-cryptonly --enable-aesgcm-siv --enable-smallstack' | ||
| name: make check (${{ matrix.config }}) | ||
| if: ${{ (github.repository_owner == 'wolfssl') && (github.event_name != 'pull_request' || github.event.pull_request.draft == false) }} | ||
| runs-on: ubuntu-24.04 | ||
| timeout-minutes: 12 | ||
| steps: | ||
| - uses: actions/checkout@v5 | ||
| name: Checkout wolfSSL | ||
|
|
||
| - name: Build and test AES-GCM-SIV | ||
| run: | | ||
| ./autogen.sh | ||
| ./configure ${{ matrix.config }} | ||
| make -j 4 | ||
| make check | ||
|
|
||
| - name: Print errors | ||
| if: ${{ failure() }} | ||
| run: | | ||
| for file in scripts/*.log test-suite.log | ||
| do | ||
| if [ -f "$file" ]; then | ||
| echo "${file}:" | ||
| cat "$file" | ||
| echo "========================================================================" | ||
| fi | ||
| done | ||
|
|
||
| # Cross-compiled AES-GCM-SIV asm paths, built out-of-tree in parallel and run | ||
| # under qemu-user (binfmt). Covers: | ||
| # - arm64-pmull : AArch64 PMULL POLYVAL (gcm_siv_arm64_crypto). | ||
| # - arm64-no-hw-crypto : AArch64 NEON 8-bit-pmul + table POLYVAL | ||
| # (gcm_siv_arm64_neon / _base) via WOLFSSL_ARMASM_NO_HW_CRYPTO. | ||
| # - armhf-crypto : ARMv8-A 32-bit vmull.p64 POLYVAL (gcm_siv_arm32_crypto); | ||
| # QEMU_CPU=max enables the crypto extensions. | ||
| # Thumb-2 (gcm_siv_thumb2) targets armv7-m, which qemu-user cannot run, so it | ||
| # is not covered here. | ||
| cross_check: | ||
| name: Cross-arch test | ||
| if: ${{ (github.repository_owner == 'wolfssl') && (github.event_name != 'pull_request' || github.event.pull_request.draft == false) }} | ||
| runs-on: ubuntu-22.04 | ||
| timeout-minutes: 25 | ||
| steps: | ||
| - uses: actions/checkout@v5 | ||
| name: Checkout wolfSSL | ||
|
|
||
| - name: Install dependencies | ||
| uses: ./.github/actions/install-apt-deps | ||
| with: | ||
| packages: autoconf automake libtool build-essential crossbuild-essential-arm64 crossbuild-essential-armhf qemu-user | ||
| ghcr-debs-tag: ubuntu-22.04-minimal | ||
|
|
||
| - name: Set up ccache | ||
| uses: ./.github/actions/ccache-setup | ||
| with: | ||
| workflow-id: aesgcm-siv | ||
| read-only: ${{ github.event_name == 'pull_request' }} | ||
| max-size: 300M | ||
|
|
||
| - name: Build all configs (parallel, out-of-tree) | ||
| run: | | ||
| cat > "$RUNNER_TEMP/aesgcm-siv-configs.json" <<'EOF' | ||
| [ | ||
| {"name": "arm64-pmull", "minutes": 6, | ||
| "cc": "ccache aarch64-linux-gnu-gcc", | ||
| "configure": ["--host=aarch64-linux-gnu", "--enable-cryptonly", | ||
| "--enable-all-crypto", "--disable-examples", "--enable-armasm", | ||
| "--enable-aesgcm-siv", "CFLAGS=-O2"], | ||
| "check": false, | ||
| "run": [["env", "QEMU_LD_PREFIX=/usr/aarch64-linux-gnu", "QEMU_CPU=max", | ||
| "./wolfcrypt/test/testwolfcrypt"]]}, | ||
| {"name": "arm64-no-hw-crypto", "minutes": 6, | ||
| "cc": "ccache aarch64-linux-gnu-gcc", | ||
| "configure": ["--host=aarch64-linux-gnu", "--enable-cryptonly", | ||
| "--enable-all-crypto", "--disable-examples", "--enable-armasm", | ||
| "--enable-aesgcm-siv", "CPPFLAGS=-DWOLFSSL_ARMASM_NO_HW_CRYPTO", | ||
| "CFLAGS=-O2"], | ||
| "check": false, | ||
| "run": [["env", "QEMU_LD_PREFIX=/usr/aarch64-linux-gnu", "QEMU_CPU=max", | ||
| "./wolfcrypt/test/testwolfcrypt"]]}, | ||
| {"name": "armhf-crypto", "minutes": 6, | ||
| "cc": "ccache arm-linux-gnueabihf-gcc", | ||
| "comment": "--disable-aesgcm-stream: WOLFSSL_AESGCM_STREAM's software GHASH only defines its macros for __aarch64__ armasm, not 32-bit __arm__ armasm, so all-crypto + armasm otherwise fails to build aes.c (pre-existing, unrelated to SIV).", | ||
| "configure": ["--host=arm-linux-gnueabihf", "--enable-cryptonly", | ||
| "--enable-all-crypto", "--disable-examples", "--enable-armasm", | ||
| "--enable-aesgcm-siv", "--disable-aesgcm-stream", "CFLAGS=-O2"], | ||
| "check": false, | ||
| "run": [["env", "QEMU_LD_PREFIX=/usr/arm-linux-gnueabihf", "QEMU_CPU=max", | ||
| "./wolfcrypt/test/testwolfcrypt"]]} | ||
| ] | ||
| EOF | ||
| .github/scripts/parallel-make-check.py \ | ||
| ${{ github.event_name == 'schedule' && '--build-only' || '' }} \ | ||
| "$RUNNER_TEMP/aesgcm-siv-configs.json" | ||
|
|
||
| - name: ccache stats | ||
| if: always() | ||
| run: ccache -s || true | ||
|
|
||
| - name: Upload logs on failure | ||
| if: failure() | ||
| uses: actions/upload-artifact@v6 | ||
| with: | ||
| retention-days: 7 | ||
| name: aesgcm-siv-cross-logs | ||
| path: | | ||
| build-*/make-check.log | ||
| build-*/test-suite.log | ||
| build-*/config.log | ||
| if-no-files-found: ignore | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.