chore(deps): remove unused glob dependency#514
Conversation
`glob` is declared as a direct dependency (^10.3.10) but is not imported anywhere in the source tree (no static or dynamic reference in src/, scripts/, or tests) — a leftover from earlier code. Removing it drops glob@10 and its private subtree (minimatch@9, jackspeak, path-scurry, foreground-child, package-json-from-dist, @isaacs/cliui, ...) from the lockfile and clears the glob@10 install-time deprecation warning. Dependencies-only; no source change. Verified: with glob removed, `npm install` and `npm run build` (tsc over the full project) succeed and the test suite passes (the sole failure, test-enhanced-repl.js, is an unrelated pre-existing env issue requiring Python on PATH). glob is still present transitively (glob@7 via archiver-utils/rimraf); this change intentionally does not touch that. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe ChangesDependency Cleanup
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
Removes
globfromdependencies. It's declared (^10.3.10) but not imported anywhere in the source tree — no static or dynamic reference insrc/,scripts/, or tests.Why
glob@10and its private subtree (minimatch@9,jackspeak,path-scurry,foreground-child,package-json-from-dist,@isaacs/cliui, …) from the lockfile — −312 lines.npm warn deprecated glob@10.5.0message at install time.20 || >=22, but this package declaresengines.node: >=18, so an upgrade would force a Node-floor change. Removal sidesteps that since the dep is unused.Scope / non-goals
glob@7is still pulled in transitively (viaarchiver-utils/rimrafunderexceljs, andnode-pre-gypunderpdf2md). Those are separate old transitives with a callback-API break across the glob major, so this PR deliberately leaves them alone.Verification
npm install✓npm run build(tsc over the full project) ✓ — confirms nothing imports globnpm test→ 39/40 ✓; the one failure (test-enhanced-repl.js) is a pre-existing, unrelated env issue (requires Python on PATH), not caused by this change.Summary by CodeRabbit