Skip to content

chore(deps): remove unused glob dependency#514

Open
gkriegspeedbay wants to merge 1 commit into
wonderwhy-er:mainfrom
gkriegspeedbay:chore/remove-unused-glob-dep
Open

chore(deps): remove unused glob dependency#514
gkriegspeedbay wants to merge 1 commit into
wonderwhy-er:mainfrom
gkriegspeedbay:chore/remove-unused-glob-dep

Conversation

@gkriegspeedbay

@gkriegspeedbay gkriegspeedbay commented Jun 15, 2026

Copy link
Copy Markdown

What

Removes glob from dependencies. It's declared (^10.3.10) but not imported anywhere in the source tree — no static or dynamic reference in src/, scripts/, or tests.

Why

  • Dropping the direct dep removes glob@10 and its private subtree (minimatch@9, jackspeak, path-scurry, foreground-child, package-json-from-dist, @isaacs/cliui, …) from the lockfile — −312 lines.
  • Clears the npm warn deprecated glob@10.5.0 message at install time.
  • Bumping instead of removing isn't viable: glob ≥11 requires Node 20 || >=22, but this package declares engines.node: >=18, so an upgrade would force a Node-floor change. Removal sidesteps that since the dep is unused.

Scope / non-goals

glob@7 is still pulled in transitively (via archiver-utils/rimraf under exceljs, and node-pre-gyp under pdf2md). Those are separate old transitives with a callback-API break across the glob major, so this PR deliberately leaves them alone.

Verification

  • npm install
  • npm run build (tsc over the full project) ✓ — confirms nothing imports glob
  • npm test → 39/40 ✓; the one failure (test-enhanced-repl.js) is a pre-existing, unrelated env issue (requires Python on PATH), not caused by this change.

Summary by CodeRabbit

  • Chores
    • Removed an unused dependency to streamline package management and reduce the overall dependency footprint.

`glob` is declared as a direct dependency (^10.3.10) but is not imported
anywhere in the source tree (no static or dynamic reference in src/,
scripts/, or tests) — a leftover from earlier code.

Removing it drops glob@10 and its private subtree (minimatch@9, jackspeak,
path-scurry, foreground-child, package-json-from-dist, @isaacs/cliui, ...)
from the lockfile and clears the glob@10 install-time deprecation warning.
Dependencies-only; no source change.

Verified: with glob removed, `npm install` and `npm run build` (tsc over the
full project) succeed and the test suite passes (the sole failure,
test-enhanced-repl.js, is an unrelated pre-existing env issue requiring
Python on PATH). glob is still present transitively (glob@7 via
archiver-utils/rimraf); this change intentionally does not touch that.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 110b3340-ecf1-4d61-a102-9418b131794c

📥 Commits

Reviewing files that changed from the base of the PR and between 7a9b2ff and 605ed78.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json
💤 Files with no reviewable changes (1)
  • package.json

📝 Walkthrough

Walkthrough

The glob package (previously pinned to ^10.3.10) is removed from the dependencies section of package.json. No other metadata, scripts, or dependency entries are modified.

Changes

Dependency Cleanup

Layer / File(s) Summary
Remove glob dependency
package.json
The glob entry (^10.3.10) is deleted from the dependencies object.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A single line vanished, so tidy and neat,
The glob said goodbye — what a feat!
No more searching required,
That package retired,
The dependency list is complete! 🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: removing an unused glob dependency from package.json.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant