Skip to content

#479: add iterate since DSL #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akmhatey-ai wants to merge 2 commits into from
+51 −0
Closed

#479: add iterate since DSL #485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a82e147
#479: add iterate since DSL
akmhatey-ai May 25, 2026
8bec1c7
Merge remote-tracking branch 'origin/master' into codex/iterate-since…
akmhatey-ai Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/fbe/iterate.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ def initialize(fb:, loog:, options:, global:, epoch:, kickoff:)
@kickoff = kickoff
@label = nil
@since = 0
@custom = false
@query = nil
@sorting = nil
@repeats = 1
Expand Down Expand Up @@ -161,9 +162,11 @@ def repeats(repeats)
# @example Start iteration from issue number 100
# iterator.since(100)
def since(value)
raise(Fbe::Error, 'Since is already set') if @custom

@yegor256 yegor256 Jun 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akmhatey-ai should be since!()

raise(Fbe::Error, 'Cannot set "since" to nil') if value.nil?
raise(Fbe::Error, 'The "since" must be an Integer') unless value.is_a?(Integer)
@since = value
@custom = true
end

# Sets the query to execute for each iteration.
Expand Down
48 changes: 48 additions & 0 deletions test/fbe/test_iterate.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,54 @@ def test_raises_when_repeats_is_not_positive
end
end

def test_configures_since_start
opts = Judges::Options.new(['repositories=foo/bar', 'testing=true'])
fb = Fbe.fb(fb: Factbase.new, global: {}, options: opts, loog: Loog::NULL)
seen = []
Fbe.iterate(fb:, loog: Loog::NULL, global: {}, options: opts, epoch: Time.now, kickoff: Time.now) do
as('custom_since_test')
since(7)
by('(plus $before 1)')
repeats(1)
over do |_, nxt|
seen << nxt
nxt
end
end
assert_equal([8], seen)
end

def test_raises_when_since_is_nil
opts = Judges::Options.new(['repositories=foo/bar', 'testing=true'])
fb = Fbe.fb(fb: Factbase.new, global: {}, options: opts, loog: Loog::NULL)
assert_raises(Fbe::Error) do
Fbe.iterate(fb:, loog: Loog::NULL, global: {}, options: opts, epoch: Time.now, kickoff: Time.now) do
since(nil)
end
end
end

def test_raises_when_since_is_not_integer
opts = Judges::Options.new(['repositories=foo/bar', 'testing=true'])
fb = Fbe.fb(fb: Factbase.new, global: {}, options: opts, loog: Loog::NULL)
assert_raises(Fbe::Error) do
Fbe.iterate(fb:, loog: Loog::NULL, global: {}, options: opts, epoch: Time.now, kickoff: Time.now) do
since('7')
end
end
end

def test_raises_when_since_set_twice
opts = Judges::Options.new(['repositories=foo/bar', 'testing=true'])
fb = Fbe.fb(fb: Factbase.new, global: {}, options: opts, loog: Loog::NULL)
assert_raises(Fbe::Error) do
Fbe.iterate(fb:, loog: Loog::NULL, global: {}, options: opts, epoch: Time.now, kickoff: Time.now) do
since(1)
since(2)
end
end
end

def test_raises_when_label_is_nil
opts = Judges::Options.new(['repositories=foo/bar', 'testing=true'])
fb = Fbe.fb(fb: Factbase.new, global: {}, options: opts, loog: Loog::NULL)
Expand Down
Loading