Fix table edits with dataframe indexes#2883
Open
xujiantop-crypto wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This fixes #2747 by allowing table edit/delete callbacks to use the dataframe index value returned by the frontend instead of requiring it to be numeric.
Dataframes with non-default indexes can now update or delete the selected row through the existing pandas index path, while the previous numeric-index behavior is preserved.
Tests
python -m ruff check taipy/gui/data/pandas_data_accessor.py tests/gui/data/test_pandas_data_accessor.pygit diff --checkI also tried
python -m pytest tests/gui/data/test_pandas_data_accessor.py -q, but this local machine only has Python 3.14 while the project declaresrequires-python = ">=3.9,<3.13"; the test run stopped during import in SQLAlchemy before reaching these tests.