Skip to content

Fix table edits with dataframe indexes #2883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xujiantop-crypto wants to merge 1 commit into
base: develop
Choose a base branch
from
+26 −2
Open

Fix table edits with dataframe indexes #2883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions taipy/gui/data/pandas_data_accessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,14 +550,14 @@ def _get_index_value(self, index: t.Any) -> t.Any:

def on_edit(self, value: t.Any, payload: t.Dict[str, t.Any]):
df = self.to_pandas(value)
if not isinstance(df, pd.DataFrame) or not isinstance(payload.get("index"), (int, float)):
if not isinstance(df, pd.DataFrame) or "index" not in payload:
raise ValueError(f"Cannot edit {type(value)} at {payload.get('index')}.")
df.at[self._get_index_value(payload.get("index", 0)), payload["col"]] = payload["value"]
return self._from_pandas(df, type(value))

def on_delete(self, value: t.Any, payload: t.Dict[str, t.Any]):
df = self.to_pandas(value)
if not isinstance(df, pd.DataFrame) or not isinstance(payload.get("index"), (int, float)):
if not isinstance(df, pd.DataFrame) or "index" not in payload:
raise ValueError(f"Cannot delete a row from {type(value)} at {payload.get('index')}.")
return self._from_pandas(df.drop(self._get_index_value(payload.get("index", 0))), type(value))

Expand Down
24 changes: 24 additions & 0 deletions tests/gui/data/test_pandas_data_accessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,18 @@ def test_edit(gui, small_dataframe):
assert ret_data["value"].iloc[0] == 10


def test_edit_dataframe_with_string_index(gui, small_dataframe):
accessor = _PandasDataAccessor(gui)
pd = pandas.DataFrame(small_dataframe, index=["row-a", "row-b", "row-c"])
ln = len(pd)

ret_data = accessor.on_edit(pd, {"index": "row-b", "col": "value", "value": 10})

assert isinstance(ret_data, pandas.DataFrame)
assert len(ret_data) == ln
assert ret_data.at["row-b", "value"] == 10


def test_delete(gui, small_dataframe):
accessor = _PandasDataAccessor(gui)
pd = pandas.DataFrame(small_dataframe)
Expand All @@ -392,6 +404,18 @@ def test_delete(gui, small_dataframe):
assert len(ret_data) == ln - 1


def test_delete_dataframe_with_string_index(gui, small_dataframe):
accessor = _PandasDataAccessor(gui)
pd = pandas.DataFrame(small_dataframe, index=["row-a", "row-b", "row-c"])
ln = len(pd)

ret_data = accessor.on_delete(pd, {"index": "row-b"})

assert isinstance(ret_data, pandas.DataFrame)
assert len(ret_data) == ln - 1
assert "row-b" not in ret_data.index


def test_add(gui, small_dataframe):
accessor = _PandasDataAccessor(gui)
pd = pandas.DataFrame(small_dataframe)
Expand Down