chore(module): fix lint and failed test#2565
Merged
Merged
Conversation
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
universal-itengineer
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two small fixes to unblock CI:
src/cli: check the return value offmt.Fprintfin the VNC test to satisfy theerrchecklinter.vmcontroller: update themigrating_test.goexpectation to match the clearer condition wording introduced in fix(api): make user-facing condition messages clearer #2558 ("Migration is in progress: target pod is being scheduled.").Why do we need it, and what problem does it solve?
The linter failed on
internal/cmd/vnc/vnc_test.go(errcheck), and the migrating condition unit test broke after the user-facing message was reworded. Both kept the pipeline red without any functional regression.What is the expected result?
task lintpasses for./src/cli.go test ./pkg/controller/vm/internal/passes.Checklist
Changelog entries
Not applicable — lint and test-only changes, no user-facing behavior change.