Skip to content

chore(module): fix lint and failed test#2565

Merged
danilrwx merged 2 commits into
mainfrom
fix/lint-and-migrating-test
Jul 1, 2026
Merged

chore(module): fix lint and failed test#2565
danilrwx merged 2 commits into
mainfrom
fix/lint-and-migrating-test

Conversation

@danilrwx

@danilrwx danilrwx commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Description

Two small fixes to unblock CI:

  • src/cli: check the return value of fmt.Fprintf in the VNC test to satisfy the errcheck linter.
  • vm controller: update the migrating_test.go expectation to match the clearer condition wording introduced in fix(api): make user-facing condition messages clearer #2558 ("Migration is in progress: target pod is being scheduled.").

Why do we need it, and what problem does it solve?

The linter failed on internal/cmd/vnc/vnc_test.go (errcheck), and the migrating condition unit test broke after the user-facing message was reworded. Both kept the pipeline red without any functional regression.

What is the expected result?

  1. task lint passes for ./src/cli.
  2. go test ./pkg/controller/vm/internal/ passes.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

Not applicable — lint and test-only changes, no user-facing behavior change.

danilrwx added 2 commits July 1, 2026 15:53
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
@danilrwx danilrwx added this to the v1.10.0 milestone Jul 1, 2026
@danilrwx danilrwx marked this pull request as ready for review July 1, 2026 13:58
@danilrwx danilrwx merged commit 0a86797 into main Jul 1, 2026
34 of 38 checks passed
@danilrwx danilrwx deleted the fix/lint-and-migrating-test branch July 1, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants