Skip to content

chore(module): fix lint and failed test #2565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danilrwx merged 2 commits into from
Jul 1, 2026
Merged

chore(module): fix lint and failed test #2565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08e08bf
fix(cli): check fmt.Fprintf return value in vnc test
danilrwx Jul 1, 2026
bbff8f0
test(vm): align migrating condition message with clearer wording
danilrwx Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion images/virtualization-artifact/pkg/controller/vm/internal/migrating_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ var _ = Describe("MigratingHandler", func() {
Expect(exists).To(BeTrue())
Expect(cond.Status).To(Equal(metav1.ConditionFalse))
Expect(cond.Reason).To(Equal(vmcondition.ReasonMigratingPending.String()))
Expect(cond.Message).To(Equal("Migration is in progress: scheduling the migration target."))
Expect(cond.Message).To(Equal("Migration is in progress: target pod is being scheduled."))
})

It("Should set active progress message when vmop is in progress with target preparing reason", func() {
Expand Down
2 changes: 1 addition & 1 deletion src/cli/internal/cmd/vnc/vnc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ var _ = Describe("VNC", func() {
// stay alive until ctx is canceled, not return immediately.
port := ln.Addr().(*net.TCPAddr).Port
Expect(port).To(BeNumerically(">", 0))
fmt.Fprintf(cmd.OutOrStdout(), "{\"port\":%d}\n", port)
_, _ = fmt.Fprintf(cmd.OutOrStdout(), "{\"port\":%d}\n", port)
<-ctx.Done()
close(connectDone)
return ctx.Err()
Expand Down
Loading