Add extra check to only set the IP Service tags if not already set#4551
Merged
Conversation
Comment out BYOIP feature registration logic for IP service tags.
Removed commented-out code for BYOIP feature registration.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Azure deployment parameter construction so user-provided ip_service_tags from the runbook are no longer overridden when the BYOIP feature is registered, preserving custom IP tag configuration.
Changes:
- Removed the BYOIP-registered conditional that injected
FirstPartyUsage=/SyntheticLoadintoarm_parameters.ip_service_tags. - Ensures
ip_service_tagspassed via runbook remain intact during_create_deployment_parameters()processing. - Consider linking the related issue for traceability (bug fix PR with no linked issue).
Comment on lines
1358
to
1359
|
|
||
| arm_parameters.virtual_network_resource_group = ( |
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
knelsonmeister
changed the title
…only if no tags are present already
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
knelsonmeister
changed the title
LiliDeng
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes setting the IP Service tags if BYOIP is enabled. The code was overwriting any IP service tags set with ip_service_tags in a runbook.
Related Issue
Type of Change
Checklist
Test Validation
Set a custom IP service tag using ip_service_tags in a runbook. Ran a LISA smoke test, and I can see the custom IP service tag in Azure with the fix.
Key Test Cases:
smoke_test
Impacted LISA Features:
Tested Azure Marketplace Images:
canonical ubuntu-24_04-lts server-arm64 latest
Test Results