Skip to content

Add extra check to only set the IP Service tags if not already set #4551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LiliDeng merged 3 commits into from
Jun 25, 2026
+3 −2
Merged

Add extra check to only set the IP Service tags if not already set #4551

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50fc7f8
Comment out BYOIP feature check in platform_.py
knelsonmeister Jun 1, 2026
5d7f017
Clean up commented code in platform_.py
knelsonmeister Jun 2, 2026
8b98c92
Add IP service tags configuration for BYOIP feature in AzurePlatform …
kevinnelson-affirmed Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lisa/sut_orchestrator/azure/platform_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1355,8 +1355,9 @@ def _create_deployment_parameters(
arm_parameters.availability_options,
availability_copied_fields,
)
if self._is_byoip_feature_registered():
arm_parameters.ip_service_tags["FirstPartyUsage"] = "/SyntheticLoad"
if not arm_parameters.ip_service_tags:
if self._is_byoip_feature_registered():
arm_parameters.ip_service_tags = {"FirstPartyUsage": "/SyntheticLoad"}
Comment thread
knelsonmeister marked this conversation as resolved.

arm_parameters.virtual_network_resource_group = (
Comment on lines 1361 to 1362
self._azure_runbook.virtual_network_resource_group
Expand Down
Loading