fix: remove beforeunload and resize listener when closing composer#13169
Draft
steven-mpawulo wants to merge 2 commits into
Draft
fix: remove beforeunload and resize listener when closing composer#13169steven-mpawulo wants to merge 2 commits into
steven-mpawulo wants to merge 2 commits into
Conversation
Signed-off-by: steven-mpawulo <stevenmpawulo@gmail.com>
steven-mpawulo
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
Member
|
Thanks for the fix |
ChristophWurst
requested changes
Jul 1, 2026
ChristophWurst
left a comment
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
I think this needs more refinement. The listeners have to be put back when you start composing the next email.
And saving any draft should be awaited, so the lines have to be pushed down after the if.
Collaborator
Author
|
Ohh, |
steven-mpawulo
force-pushed
the
fix/13031-confirmation-popup-before-leaving
branch
from
23f7247 to
3276703
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed beforeunload and resize listeners
Fixes #13031