Skip to content

fix: remove beforeunload and resize listener when closing composer #13169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
steven-mpawulo wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −0
Draft

fix: remove beforeunload and resize listener when closing composer #13169

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d243ad7
fix: remove beforeunload and resize listener when closing composer
steven-mpawulo Jun 26, 2026
3276703
refactor: adjust removal of listerners
steven-mpawulo Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/components/NewMessageModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,6 +631,9 @@ export default {
this.mainStore.setComposerIndicatorDisabledMutation(true)
await this.onMinimize()

window.removeEventListener('beforeunload', this.onBeforeUnload)
window.removeEventListener('resize', this.checkScreenSize)

// End the session only if all unsaved changes have been saved
if (this.canSaveDraft && ((this.changed && this.draftSaved) || !this.changed)) {
logger.debug('Closing composer session due to close button click')
Expand Down
Loading