Skip to content

[codex] Remove COORDINATE_SYSTEM.IDENTITY alias#10376

Open
charlieforward9 wants to merge 1 commit into
masterfrom
codex/remove-coordinate-system-identity
Open

[codex] Remove COORDINATE_SYSTEM.IDENTITY alias#10376
charlieforward9 wants to merge 1 commit into
masterfrom
codex/remove-coordinate-system-identity

Conversation

@charlieforward9

@charlieforward9 charlieforward9 commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

Goal

Remove the deprecated COORDINATE_SYSTEM.IDENTITY compatibility alias for the v10 cleanup.

Changes

  • Removed the deprecated Object.defineProperty(COORDINATE_SYSTEM, 'IDENTITY', ...) getter and its warning-only log import.
  • Replaced active test app and showcase usages with COORDINATE_SYSTEM.CARTESIAN.
  • Removed unit-test coverage that only asserted the deprecated alias behavior.

Documentation

  • Add this to the v10 What's New / release notes: COORDINATE_SYSTEM.IDENTITY has been removed; use COORDINATE_SYSTEM.CARTESIAN instead.

Validation

  • yarn test-headless test/modules/core/shaderlib/project/project-functions.spec.ts test/modules/core/shaderlib/project/viewport-uniforms.spec.ts test/modules/mesh-layers/utils.spec.ts
  • Pre-commit hook during commit: module/test/example lint and Prettier checks, lockfile validation, node Vitest smoke tests. Existing lint warnings were reported, with 0 errors.

@charlieforward9 charlieforward9 added this to the v10 milestone Jun 13, 2026 — with ChatGPT Codex Connector
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 83.389% (-0.002%) from 83.391% — codex/remove-coordinate-system-identity into master

@charlieforward9 charlieforward9 marked this pull request as ready for review June 13, 2026 07:00
@chrisgervang

Copy link
Copy Markdown
Collaborator

Let's hold on merging while we focus master on 9.4 betas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants