[codex] Remove COORDINATE_SYSTEM.IDENTITY alias

modules/core/src/lib/constants.ts

@@ -2,7 +2,6 @@
 // SPDX-License-Identifier: MIT
 // Copyright (c) vis.gl contributors
 
-import log from '../utils/log';
 import {Pan, InputDirection, Pinch, Tap} from 'mjolnir.js';
 import type {PanRecognizerOptions, PinchRecognizerOptions, TapRecognizerOptions} from 'mjolnir.js';
 
@@ -52,16 +51,6 @@ export const COORDINATE_SYSTEM = {
   CARTESIAN: 'cartesian'
 } as const;
 
-// Deprecated
-/* eslint-disable accessor-pairs */
-Object.defineProperty(COORDINATE_SYSTEM, 'IDENTITY', {
-  get: () => {
-    log.deprecated('COORDINATE_SYSTEM.IDENTITY', 'COORDINATE_SYSTEM.CARTESIAN')();
-    return COORDINATE_SYSTEM.CARTESIAN;
-  }
-});
-/* eslint-enable accessor-pairs */
-
 /**
  * How coordinates are transformed from the world space into the common space.
  */

showcases/ascii/ascii-layer/ascii-layer.js

@@ -110,7 +110,7 @@ export default class AsciiLayer extends CompositeLayer {
 
     return new IconLayer({
       id: 'text',
-      coordinateSystem: COORDINATE_SYSTEM.IDENTITY,
+      coordinateSystem: COORDINATE_SYSTEM.CARTESIAN,
       data: grid,
       opacity: 1,
       iconAtlas,

showcases/graph/graph-layer/graph-layer.js

@@ -6,7 +6,7 @@ import {CompositeLayer, IconLayer, LineLayer, ScatterplotLayer, COORDINATE_SYSTE
 
 const defaultProps = {
   offset: {x: 0, y: 0},
-  coordinateSystem: COORDINATE_SYSTEM.IDENTITY,
+  coordinateSystem: COORDINATE_SYSTEM.CARTESIAN,
 
   getLinkPosition: link => ({
     sourcePosition: [link.source.x, link.source.y],

showcases/graph/graph-layer/graph-layout-layer.js

@@ -13,7 +13,7 @@ const defaultProps = {
   data: null,
   opacity: 1.0,
   layout: LayoutD3,
-  coordinateSystem: COORDINATE_SYSTEM.IDENTITY,
+  coordinateSystem: COORDINATE_SYSTEM.CARTESIAN,
   nodeIconAccessors: {}
 };
 

test/apps/standalone/index.js

@@ -54,7 +54,7 @@ const nonGeoExample = new deck.DeckGL({
   layers: [
     new deck.PointCloudLayer({
       id: 'pointCloud',
-      coordinateSystem: deck.COORDINATE_SYSTEM.IDENTITY,
+      coordinateSystem: deck.COORDINATE_SYSTEM.CARTESIAN,
       opacity: 1,
       data: points,
       getPosition: d => d.position,

test/apps/svg-interoperability/app.jsx

@@ -141,7 +141,7 @@ class Root extends PureComponent {
       ],
       getRadius: p => 2,
       getColor: p => [255, 0, 128, 196],
-      coordinateSystem: COORDINATE_SYSTEM.IDENTITY,
+      coordinateSystem: COORDINATE_SYSTEM.CARTESIAN,
       // there's a bug that the radius calculated with project_scale
       radiusMinPixels: 2
     });
@@ -172,7 +172,7 @@ class Root extends PureComponent {
         p.radius * Math.cos(p.theta * DEGREE_TO_RADIAN) * size,
         p.radius * Math.sin(p.theta * DEGREE_TO_RADIAN) * size
       ],
-      coordinateSystem: COORDINATE_SYSTEM.IDENTITY,
+      coordinateSystem: COORDINATE_SYSTEM.CARTESIAN,
       cellSize: 20,
       contours: this._getContours(bandsOn),
       gpuAggregation: true

test/apps/video/app.jsx

@@ -37,7 +37,7 @@ export class App extends Component {
 
   _renderLayers() {
     return new BitmapLayer({
-      coordinateSystem: COORDINATE_SYSTEM.IDENTITY,
+      coordinateSystem: COORDINATE_SYSTEM.CARTESIAN,
       image: this._videoRef.current,
       bounds: [-300, -400, 400, 300]
     });

test/modules/core/shaderlib/project/project-functions.spec.ts

@@ -160,17 +160,6 @@ test('project#projectPosition rejects legacy numeric coordinate systems', () =>
       }),
     'Legacy numeric coordinate systems are rejected'
   ).toThrow(/Invalid coordinateSystem/);
-
-  const identityResult = projectPosition([0, 0, 0], {
-    viewport: TEST_VIEWPORT,
-    coordinateSystem: COORDINATE_SYSTEM.IDENTITY,
-    coordinateOrigin: [256, 256, 0]
-  });
-
-  expect(
-    equals(identityResult, [174.15110778808594, -58.11044311523443, 0]),
-    'IDENTITY aliases cartesian behavior'
-  ).toBeTruthy();
 });
 
 webglTest('project#projectPosition vs project_position', async () => {

test/modules/core/shaderlib/project/viewport-uniforms.spec.ts

@@ -171,19 +171,6 @@ test('project#getUniforms rejects legacy numeric coordinate systems', () => {
   ).toThrow(/Invalid coordinateSystem/);
 });
 
-test('project#getUniforms normalizes IDENTITY to CARTESIAN', () => {
-  const cartesian = project.getUniforms({
-    viewport: TEST_VIEWPORTS.infoVis,
-    coordinateSystem: COORDINATE_SYSTEM.CARTESIAN
-  });
-  const identity = project.getUniforms({
-    viewport: TEST_VIEWPORTS.infoVis,
-    coordinateSystem: COORDINATE_SYSTEM.IDENTITY
-  });
-
-  expect(identity, 'IDENTITY matches CARTESIAN').toEqual(cartesian);
-});
-
 test('project64#getUniforms', () => {
   const viewport = TEST_VIEWPORTS.map;
   const uniforms = project.getUniforms({viewport});

test/modules/mesh-layers/utils.spec.ts

@@ -16,8 +16,8 @@ test('shouldComposeModelMatrix', () => {
     'Should not composeModelMatrix for lnglat.'
   ).toBeFalsy();
   expect(
-    shouldComposeModelMatrix({}, COORDINATE_SYSTEM.IDENTITY),
-    'Should composeModelMatrix for identity.'
+    shouldComposeModelMatrix({}, COORDINATE_SYSTEM.CARTESIAN),
+    'Should composeModelMatrix for cartesian.'
   ).toBeTruthy();
   expect(
     shouldComposeModelMatrix({}, COORDINATE_SYSTEM.METER_OFFSETS),