Skip to content

a11y: Keyboard navigation; aria attributes #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doubleedesign wants to merge 1 commit into
base: master
Choose a base branch
from
Open

a11y: Keyboard navigation; aria attributes #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/javascript/vanilla-js-dropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,12 @@ var CustomSelect = function(options) {

button.className = titleClass;
button.textContent = selectOptions[0].textContent;
button.setAttribute('aria-expanded', false);

// creating the UL
var ul = document.createElement('ul');
ul.className = listClass;
ul.setAttribute('aria-hidden', true);

// dealing with optgroups
if (selectOpgroups.length) {
Expand All @@ -64,6 +66,11 @@ var CustomSelect = function(options) {
selectContainer.appendChild(ul);

selectContainer.addEventListener('click', onClick);
selectContainer.addEventListener('keypress', function(event) {
if (event.key === 'Enter') {
onClick(event);
}
});

// pseudo-select is ready - append it and hide the original
elem.parentNode.insertBefore(selectContainer, elem);
Expand All @@ -81,6 +88,7 @@ var CustomSelect = function(options) {
li.innerText = options[i].textContent;
li.setAttribute('data-value', options[i].value);
li.setAttribute('data-index', index++);
li.setAttribute('tabindex', '0');

if (selectOptions[elem.selectedIndex].textContent === options[i].textContent) {
li.classList.add(selectedClass);
Expand Down Expand Up @@ -141,6 +149,8 @@ var CustomSelect = function(options) {
*/
function toggle() {
ul.classList.toggle(openClass);
ul.toggleAttribute('aria-hidden');
button.toggleAttribute('aria-expanded');
}

/**
Expand All @@ -150,6 +160,8 @@ var CustomSelect = function(options) {
*/
function open() {
ul.classList.add(openClass);
ul.setAttribute('aria-hidden', false);
button.setAttribute('aria-expanded', true);
}

/**
Expand All @@ -159,6 +171,8 @@ var CustomSelect = function(options) {
*/
function close() {
ul.classList.remove(openClass);
ul.setAttribute('aria-hidden', true);
button.setAttribute('aria-expanded', false);
}

return {
Expand Down